Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes warning for newer PHP versions #15376

Merged
merged 1 commit into from Jan 11, 2020
Merged

Fixes warning for newer PHP versions #15376

merged 1 commit into from Jan 11, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 10, 2020

Change should be safe. MySQLi Adapter already checks it that way:

See https://github.com/matomo-org/matomo/blob/3.x-dev/core/Tracker/Db/Mysqli.php#L46-L50

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Jan 10, 2020
@sgiehl sgiehl added this to the 3.13.1 milestone Jan 10, 2020
@tsteur tsteur merged commit 4579ba2 into 3.x-dev Jan 11, 2020
@tsteur tsteur deleted the fixwarning branch January 11, 2020 02:45
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants