Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support email address in getTokenAuth #15371

Merged
merged 2 commits into from Jan 12, 2020
Merged

Support email address in getTokenAuth #15371

merged 2 commits into from Jan 12, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 10, 2020 •
edited

Fix matomo-org/matomo-mobile-2#5404

Not writing a test for it as I'm removing this API method as part of #6559 anyway.

Not sure we can have this as part of Matomo 3.13.1? Feel free to close the PR as the method will be removed anyway in Matomo 4 so can also just close the PR

@tsteur
Support email address in getTokenAuth
c3998fd 
Fix matomo-org/matomo-mobile-2#5404

Not writing a test for it as I'm removing this API method as part of #6559 anyway.
@tsteur
Update API.php
cde83f2
@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 10, 2020
@tsteur tsteur added this to the 3.13.1 milestone Jan 10, 2020
@tsteur tsteur mentioned this pull request Jan 10, 2020
Closed
@tsteur tsteur merged commit e775c3c into 3.x-dev Jan 12, 2020
@tsteur tsteur deleted the 5404_mobile branch January 12, 2020 19:51
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tsteur @jonasgrilleres
Support email address in getTokenAuth (matomo-org#15371)
54f58ff 
* Support email address in getTokenAuth

Fix matomo-org/matomo-mobile-2#5404

Not writing a test for it as I'm removing this API method as part of matomo-org#6559 anyway.

* Update API.php
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tsteur @jbuget
Support email address in getTokenAuth (matomo-org#15371)
d279482 
* Support email address in getTokenAuth

Fix matomo-org/matomo-mobile-2#5404

Not writing a test for it as I'm removing this API method as part of matomo-org#6559 anyway.

* Update API.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

Login by email + password
1 participant
@tsteur