Save concatenated less file on compiling error so we can better debug issues. #15370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Jan 10, 2020
| @@ -46,6 +47,9 @@ protected function getMergedAssets() | |||
| try { | |||
| $compiled = $this->lessCompiler->compile($concatenatedAssets); | |||
| } catch(\Exception $e) { | |||
| // save the concated less files so we can debug the issue | |||
| $this->saveConcatenatedAssets($concatenatedAssets); | |||
There was a problem hiding this comment.
@diosmosis would that be only something for dev mode? Although I suppose it should be fine and not cause much of an issue.
There was a problem hiding this comment.
This is to help debug a cloud error, so it would ideally be available in a prod setup. Without the concatted less files, debugging the error is basically impossible.
mattab
changed the title
mattab
added
the
c: Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.