Avoid using getmypid #15364
Merged
Avoid using getmypid #15364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
It might need to be cached and the same one used for the entire run (not too sure, just thinking) |
|
@diosmosis was adding the cache but then noticed this was making things worse as cache can be reset any time and then new PID was generated. The original simple logic worked actually fine after looking into it a bit more but figured better to create a method in |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
* Avoid using getmypid * use cache for pid * revert previous change and not use cache * Added method for getmypid
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
* Avoid using getmypid * use cache for pid * revert previous change and not use cache * Added method for getmypid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@diosmosis was getting this error a few times:
I wonder if we could simply generate a random number instead of using
getmypid? I noticed the class is always used through DI so in the end the instance should be only created once and therefore thepidshould always be the same even though the property is not static. Could also make it static though if that helps and only set it once?Not too important for 3.13.1 but be good. We can move it to 4.0 though and I patch later Matomo for WordPress after the 3.13.1 release