Use tracker cache in ArchiveInvalidator so extra query is not needed. #15358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
tsteur
reviewed
Jan 8, 2020
|
|
||
| private function getRememberedArchivedReportsOptionFromTracker($idSite, $dateStr) | ||
| { | ||
| $cacheKey = self::TRACKER_CACHE_KEY; |
There was a problem hiding this comment.
Ideally, it would check whether we are in tracker mode and then read it from cache, or otherwise use the result directly. Otherwise we have to basically launch Matomo in tracker mode during a regular request. Seems to be eg used in DataSubjects which is not a tracking request.
tsteur
reviewed
Jan 8, 2020
core/Archive/ArchiveInvalidator.php
Outdated
| $suffix = substr($name, strlen($this->rememberArchivedReportIdStart)); | ||
| list($idSite, $dateStr) = explode('_', $suffix); | ||
|
|
||
| $all[$idSite][$dateStr][$name] = $value; |
There was a problem hiding this comment.
Probably not too important but [$name] could be removed? It doesn't look at this one in the cached tracker value and it would also prevent that when 200 tracking requests at the same time use the option::set that we have 200 keys in there for the same idSite,dateStr combination
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
…matomo-org#15358) * Use tracker cache in ArchiveInvalidator so extra query is not needed. * apply review fixes * applied another feedback item
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
…matomo-org#15358) * Use tracker cache in ArchiveInvalidator so extra query is not needed. * apply review fixes * applied another feedback item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15338