Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong number format for thousands in languages different by english #15356

Closed
tassoman opened this issue Jan 7, 2020 · 4 comments
Closed

Wrong number format for thousands in languages different by english #15356

tassoman opened this issue Jan 7, 2020 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@tassoman
Copy link
Contributor

tassoman commented Jan 7, 2020

I'm reading stats overview in italian and I get a decimal value for total visit.
(I didn't cut in halfs any visitor, I still love them entirely ✂️ 🔪 ) So I expected total visits as an integer.

Thousands visits in Italian are 284.628 but this number gets rounded at 284,63.

Screenshot_2020-01-07 - 2019 - Report Web Analytics - Matomo
Screenshot_2020-01-07 - 2019 - Web Analytics Reports - Matomo

Italian and English have different separators for Thousands and tenths.
Number formatting should be sourced by an integer (284628) then formatted to destination language only once.

@tassoman
Copy link
Contributor Author

tassoman commented Jan 7, 2020

Related to #15026 and #14945

@tsteur
Copy link
Member

tsteur commented Jan 7, 2020

@tassoman maybe this was fixed already? Could you test the latest beta maybe?

refs #15200

@tassoman
Copy link
Contributor Author

tassoman commented Jan 8, 2020

I can try only if there aren't any database upgrade between 3.12 and master 🤔
In the mean time I'm fine overwriting macros.twig inside a custom theme plugin reverting this commit f1d6cc7

@Findus23
Copy link
Member

Findus23 commented Jan 8, 2020

@tassoman You could also manually apply the patch from #15218 which should be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

3 participants