Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasConsent() is used in tracker so can't be a debug method #15351

Merged
merged 1 commit into from Jan 6, 2020

Conversation

diosmosis
Copy link
Member

Otherwise there'll be a JS error when the opt out frame is used w/ the minified JS.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 6, 2020
@diosmosis diosmosis added this to the 3.13.1 milestone Jan 6, 2020
@tsteur
Copy link
Member

tsteur commented Jan 6, 2020

Looks good if tests pass

@diosmosis diosmosis merged commit 5ae8668 into 3.x-dev Jan 6, 2020
@diosmosis diosmosis deleted the js-tracker-debug-func branch January 6, 2020 02:09
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 6, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants