Prevent double slash in URL when loading a script #15350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs #15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
tsteur
added
not-in-changelog
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs matomo-org#15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs matomo-org#15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise generates a URL like
https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise
['./additional=plugins/', 'AbTesting', '...'].join(). ThepluginsToWebRootDirCacheis only used for that purpose.refs #15340
This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The
$pluginsToWebRootDirCacheis only used for that purpose to load these files through http404check