Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use get_results in mysqli as it requires mysqlnd #15348

Merged
merged 2 commits into from Jan 5, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 5, 2020

fix #15345

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 5, 2020
@tsteur tsteur added this to the 3.13.1 milestone Jan 5, 2020
$refs = array();
foreach ($values as $i => &$f) {
$refs[$i] = &$f;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is $refs needed? It doesn't seem to be used anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was done like this in Zend I suppose it turns it into a reference.

Copy link
Member

@diosmosis diosmosis Jan 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zend is weird

@diosmosis diosmosis merged commit 1abde17 into 3.x-dev Jan 5, 2020
@diosmosis diosmosis deleted the 15345 branch January 5, 2020 23:34
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
…5348)

* Do not use get_results in mysqli as it requires mysqlnd

* Update Model.php
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
…5348)

* Do not use get_results in mysqli as it requires mysqlnd

* Update Model.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matomo 3.13.1.b2 : Call to undefined method mysqli_stmt::get_result()
2 participants