New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom plugin directory not working properly on some plugins #15340
Comments
Could you let us know how you configured your Matomo On-Premise re the paths? Be great to know roughly the structure of the Matomo path and the custom plugin path. Also: Are you using the latest version of Matomo? As we fixed some things there |
Hello Currently working on 3.13.0 (latest version on Docker Hub); since I'm using the Docker image, my custom path is defined as an envvar. The custom directory and the Matomo plugins directory are at the same level, so at the root of Matomo. Thank you, |
It's a bit funny it works with Funnel but not with the other two plugins. I'm using it here with HeatmapSessionRecording and Funnels in a custom plugin dir and it works nicely. In case you are familiar with the browser developer tools, in the And is I suppose as a result these plugins don't work for you in the Matomo UI? |
AbTesting: "./additional-plugins/"
ActivityLog: "./additional-plugins/"
Funnels: "./additional-plugins/"
HeatmapSessionRecording: "./additional-plugins/"
LoginSaml: "./additional-plugins/"
QueuedTracking: "./additional-plugins/"
ReferrersManager: "./additional-plugins/"
TasksTimetable: "./additional-plugins/"
UsersFlow: "./additional-plugins/"
There is an HTML file attached,
No they're not unfortunately, |
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs #15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
So it is trying to load and And these return a 404 error. Do you know what the correct URL should be that works? For me everything seems to be working fine so far. Are these plugins basically located in a directory named Because if so, it looks like Matomo generates the correct URL but it might be a webserver issue that these files cannot be found? |
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs #15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
Hello, As i've seen in your commit, my problem will not be solved because of this "//". Thank you very much for your precious help. |
If the double slash won't solve it, it be great to know what the URL should look like. This way we can better understand what is going wrong. |
Hello guys, I've checked our nginx config, the .html files are allowed from any source. But I've seen in our logs that sometimes they're requests to the plugins from the classical folder and not the custom one. I dont think the issue is on your side anymore, if I find how to solve it, I will let you know ! Regards, |
Awesome, that be really great as it will help when others face this issue. I will close the issue for now but be great if you could still commend about what you find and we can reopen the issue also any time if needed. |
Hello guys, I'm a man of word, so i've finally found the issue. Our matomo is not in the same container as our nginx, and the nginx container had a additional-plugins folder, but it was empty.. To solve it, I've just binded the volume containing the custom plugins to Matomo and Nginx and its working properly. Regards, |
Awesome @JugurthaK Thanks a lot for making the effort to letting us know. Very appreciated 👍 |
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs matomo-org#15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
Otherwise generates a URL like `https://example.com/additional-plugins//AbTesting/angularjs/manage/manage.directive.html?cb=303` In https://github.com/matomo-org/matomo/blob/3.13.1-b2/plugins/CoreHome/angularjs/http404check.js#L29 there will be otherwise `['./additional=plugins/', 'AbTesting', '...'].join()`. The `pluginsToWebRootDirCache ` is only used for that purpose. refs matomo-org#15340 This should not fix the referenced issue as a double slash should not cause any issue AFAIK but be still good to make that right. The `$pluginsToWebRootDirCache ` is only used for that purpose to load these files through http404check
Hello,
This issue is related to Issue#14717 ;
When going to premium plugins as ABTesting or SessionRecording on left panel, I've an error referring to a 404 with the following path :
./custom-folder//HeatmapSessionRecording/angularjs
When we've initialized our custom folder, it was without any "/" at the end,
Regards,
The text was updated successfully, but these errors were encountered: