Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional options query per tracking request #15338

Closed
tsteur opened this issue Jan 1, 2020 · 1 comment · Fixed by #15358
Closed

Additional options query per tracking request #15338

tsteur opened this issue Jan 1, 2020 · 1 comment · Fixed by #15358
Labels
c: Performance For when we could improve the performance / speed of Matomo. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.13.1

Comments

@tsteur
Copy link
Member

tsteur commented Jan 1, 2020

On every regular request we are now performing an option select query in https://github.com/matomo-org/matomo/blob/3.13.1-b1/core/Archive/ArchiveInvalidator.php#L71 caused by report invalidation in https://github.com/matomo-org/matomo/blob/3.13.1-b1/core/Tracker/Visit.php#L581

This was changed when removing temporary archives in #14639 since every request might now invalidate a previous archive. Before this was only executed when tracking data into a previous day that is not today and therefore rather rare.

Can we maybe use this option like % query use a cache? That would mean though we also need to invalidate the cache when this flag is removed.

Not sure if there is a different alternative.

@mattab marking this for now as a regression since we don't want additional queries like these for each tracking request. Feel free to change it.
@tsteur tsteur added c: Performance For when we could improve the performance / speed of Matomo. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jan 1, 2020
@tsteur tsteur added this to the 3.13.1 milestone Jan 1, 2020
@mattab
Copy link
Member

mattab commented Jan 8, 2020

@tsteur yes this is a regression.

@diosmosis diosmosis mentioned this issue Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging a pull request may close this issue.

Use tracker cache in ArchiveInvalidator so extra query is not needed. matomo-org/matomo
2 participants
@tsteur @mattab