@tsteur opened this Pull Request on January 1st 2020 Member

fix https://github.com/matomo-org/matomo/issues/15320
refs https://github.com/matomo-org/matomo/pull/15337
fyi @mattab @diosmosis

I wonder if maybe the query should be actually and user_id is null or user_id = $userIdFromRequestIfGiven?

Edit: Added the or user_id = ?

@diosmosis commented on January 1st 2020 Member

code looks good to me, and the user_id = ? addition makes sense to me after thinking about it. might be good to have a test (if current tests aren't already affected), otherwise looks good to me.

@tsteur commented on January 2nd 2020 Member

@diosmosis I'll merge for now. We'll see what comes out of https://github.com/matomo-org/developer-documentation/pull/320 re forcing new visits

This Pull Request was closed on January 2nd 2020
Powered by GitHub Issue Mirror