Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors if limitVisits is <= 0. #15336

Merged
merged 1 commit into from Dec 31, 2019
Merged

Prevent errors if limitVisits is <= 0. #15336

merged 1 commit into from Dec 31, 2019

Conversation

diosmosis
Copy link
Member

If set to 0 or less than 0, all rows will be removed from result set, but the code assumes at least one row exists, which results in errors.

If set to 0 or less than 0, all rows will be removed from result set, but the code assumes at least one row exists, which results in errors.
@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 31, 2019
@diosmosis diosmosis added this to the 3.13.1 milestone Dec 31, 2019
@diosmosis diosmosis merged commit 279cf80 into 3.x-dev Dec 31, 2019
@diosmosis diosmosis deleted the prevent-warning branch December 31, 2019 23:44
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
If set to 0 or less than 0, all rows will be removed from result set, but the code assumes at least one row exists, which results in errors.
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
If set to 0 or less than 0, all rows will be removed from result set, but the code assumes at least one row exists, which results in errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants