Fix archiving when getmypid is disabled #15330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
reviewed
Dec 31, 2019
| @@ -130,7 +132,11 @@ private function buildRememberArchivedReportIdForSiteAndDate($idSite, $date) | |||
| private function buildRememberArchivedReportIdProcessSafe($idSite, $date) | |||
| { | |||
| $id = $this->buildRememberArchivedReportIdForSiteAndDate($idSite, $date); | |||
| $id .= '_' . getmypid(); | |||
| if (Process::isMethodDisabled('getmypid')) { | |||
| $id .= '_' . Common::getRandomString(); | |||
There was a problem hiding this comment.
Should we cache the value of Common::getRandomString() so the same value gets used next time (to simulate a real PID)?
There was a problem hiding this comment.
@diosmosis this method should be executed max once per request as the next time the option is set... could even always use getRandomInt in theory
There was a problem hiding this comment.
I see, makes sense 👍 will merge
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
* Fix archiving when getmypid is disabled * Update ArchiveInvalidator.php * Update ArchiveInvalidator.php
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
* Fix archiving when getmypid is disabled * Update ArchiveInvalidator.php * Update ArchiveInvalidator.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See matomo-org/matomo-for-wordpress#163 (comment)
Seems this fixes some PHP bug or so. More explanation in above link