@diosmosis opened this Pull Request on December 27th 2019 Member
@sgiehl commented on December 28th 2019 Member

@mattab could you maybe get in touch with DB-IP, to get access to their paid databases? maybe also the one including ISP data? Would be good if we could test those as well.

@tsteur commented on December 29th 2019 Member

BTW haven't looked at the code but do we want to auto update the URL for people using the free maxmind DB?

@sgiehl commented on December 29th 2019 Member

guess it would make sense to do that in an update script

@mattab commented on December 29th 2019 Member

could you maybe get in touch with DB-IP, to get access to their paid databases? maybe also the one including ISP data? Would be good if we could test those as well.

Just requested to db-ip team if they're willing to send us a commercial DB set, will let you know when we hear back. Btw i noticed the commercial DBs are quite large, see:
Screenshot from 2019-12-30 09-49-09

Would this still work fine even though the DB can be up to 4DB large?

@diosmosis commented on December 29th 2019 Member

Looks like those are for the CSV files, the mmdb files are smaller. Though they still seem to be quite large (~350mb for city db). The download might take a while but for once a month it should be ok?

EDIT: I'm also not sure if that's gzipped or not.

@diosmosis commented on December 29th 2019 Member

Updated the PR

@mattab commented on January 1st 2020 Member

FYI @diosmosis our affiliate link for db-ip.com is https://db-ip.com/?refid=mtm or especially appending ?refid=mtm to all links to db-ip.com. With maxmind we had a similar affiliate link. Can you check and add the parameter to all links within the app to db-ip.com?

@diosmosis commented on January 2nd 2020 Member

@sgiehl @tsteur updated to work w/ purchased dbip urls. tested w/ all of them and tested w/ geolite2 city just to make sure it still works.

@tsteur commented on January 2nd 2020 Member

BTW: Not sure if important... once it failed for me and then I got this notice:

Notice: Undefined index: region_code in plugins/GeoIp2/LocationProvider/GeoIp2.php on line 101

@diosmosis commented on January 2nd 2020 Member

@tsteur should be fixed, let me know if you still get it

@mattab commented on January 8th 2020 Member

@diosmosis @sgiehl As soon as this is merged we'll release another beta for testing, looking forward to getting it merged today or tomorrow :rocket:

This Pull Request was closed on January 8th 2020
Powered by GitHub Issue Mirror