Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more PHP 7.4 issues #15315

Merged
merged 2 commits into from Dec 26, 2019
Merged

Fix more PHP 7.4 issues #15315

merged 2 commits into from Dec 26, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 23, 2019

fix #15288

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 23, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 23, 2019
composer.lock Outdated Show resolved Hide resolved
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the test failures are unrelated to this PR, so should be fine to merge

@tsteur tsteur merged commit 32976b7 into 3.x-dev Dec 26, 2019
@tsteur tsteur deleted the 15288 branch December 26, 2019 23:43
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Even more php 7.4 errors
2 participants