Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log tmp segment may be too long #15312

Merged
merged 3 commits into from Dec 31, 2019
Merged

Fix log tmp segment may be too long #15312

merged 3 commits into from Dec 31, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 23, 2019

Noticed #15276 does not actually work since it doesn't take into consideration the DB prefix.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 23, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 23, 2019
@mattab
Copy link
Member

mattab commented Dec 23, 2019

@tsteur LGTM. Although did you mean to include the 2fa improvements in the PR?

Looking forward to having this in a new Matomo WordPress release 👍

@tsteur tsteur merged commit f11b182 into 3.x-dev Dec 31, 2019
@tsteur tsteur deleted the logtmpsegmenttabletoolong branch December 31, 2019 01:14
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
* Fix log tmp segment may be too long

* fix tests
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
* Fix log tmp segment may be too long

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants