Ignore disableCookie setting when giving consent / removing consent #15309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to merge it Note, we would also need to update the faq explaining how to disable cookies to mention that this cookie will not be disabled and why. |
|
added some doc to https://matomo.org/faq/general/faq_157/ and https://matomo.org/faq/general/faq_146/ |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be needed for #15184
No preference if we merge or not. I would say it makes sense to merge though since it is in the interest of the user to know whether the user has opted out or removed consent etc. The cookie itself is just a 0/1 and can't identify anyone particularly and it is in the clear interest of the user to persist this cookie I would say. It is pretty much a preference cookie.
Any thoughts @mattab @Findus23