Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pivot by if comparison is enabled. #15305

Merged
merged 1 commit into from Dec 22, 2019
Merged

Conversation

diosmosis
Copy link
Member

Pivoting can sometimes try to access subtables, and in comparison mode subtables must be obtained from various other reports. Currently it's not a simple task to make it work in this case so we should disable it.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 22, 2019
@diosmosis diosmosis added this to the 3.13.1 milestone Dec 22, 2019
@tsteur tsteur merged commit a9a94e9 into 3.x-dev Dec 22, 2019
@tsteur tsteur deleted the disable-pivot-by-comparison branch December 22, 2019 18:24
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants