Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render goal when no goal name defined #15303

Merged
merged 1 commit into from Dec 22, 2019
Merged

Don't render goal when no goal name defined #15303

merged 1 commit into from Dec 22, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 22, 2019 •
edited

I think this prevented in my case some segmentation fault (or it exists without reporting or something weird is happening under circumstances)

My action looks eg like this:

DEBUG Live[2019-12-22 02:54:11 UTC] [c333b] {"type":"goal","goalName":null,"goalId":null,"idpageview":"3f08db","revenue":"0.1","goalPageId":"18461104","serverTimePretty":"Jul 31, 2019 18:43:12","url":"..../user-guide/video-actions-reports-page-views-downloads-clicks/%3Cspan%20class=","icon":"plugins/Morpheus/images/goal.png","iconSVG":"plugins/Morpheus/images/goal.svg","title":"Goal conversion","subtitle":" (\u20ac0.10 revenue)","timestamp":1564598592}

@tsteur
Don't render goal when no goal name defined
e854729 
I think this prevented in my case some segmentation fault
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 22, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 22, 2019
@diosmosis diosmosis merged commit 804b108 into 3.x-dev Dec 22, 2019
@diosmosis diosmosis deleted the norendergoalname branch December 22, 2019 06:32
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tsteur @jonasgrilleres
Don't render goal when no goal name defined (matomo-org#15303)
41771ba 
I think this prevented in my case some segmentation fault
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tsteur @jbuget
Don't render goal when no goal name defined (matomo-org#15303)
9f0c891 
I think this prevented in my case some segmentation fault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis