New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new column in all reports for % percentage of visits #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if needed, handle ecommerce columns
…to tableMetadata and generate ratio in view
… once, it is still not 100% right as the same total value is set for each dataTable
…ith dataTable\maps, probably there will be still an issue with idSubtables
…datatable\map and a subtable
…re we get all rows, not only the filtered ones
…only have to request the first level dataTable in case it is a subtable
…ue is smaller than the report value to workaround reportTotalUniquePageviews are compared with Visits because UniquePageviews uses metric nb_visits
… not the case for instance if flat=1. Reproduceable if clicking flatten in custom variables
…t over API.getProcessedReport
…rings in case for instance when handling period=month
…not set. This means basically "do not run datamanipulators". It happens for instance when flat is enabled and it tries to load all subtables, there should be no need to calculate the datatable for each of those then
…nges when needed
tsteur
added a commit
that referenced
this pull request
Nov 21, 2013
Add a new column in all reports for % percentage of visits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.