Make sure unprocessed segment notification is still shown and include notifications in UI test. #15296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… notifications in UI test.
diosmosis
added
Bug
|
LGTM. Not sure if any of the UI test failures is maybe due to this? https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37434/UIIntegrationTest_visitors_overview_segment.png Feel free to merge |
|
That one's a travis-ci issue, same thing that happens to the system test build. I did some digging a while back and it happens to another project on php 5, but not php 7. |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
… notifications in UI test. (matomo-org#15296)
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
… notifications in UI test. (matomo-org#15296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the unprocessed segment notification has been broken for a bit. This should fix it.