@brainfoolong opened this Issue on December 19th 2019 Contributor

Here are more php 7.4 errors running on 3.13.0

19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 236
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 250
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 250
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 257
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 259
[19-Dec-2019 05:26:44 UTC] PHP Notice:  Trying to access array offset on value of type int in C:\www\piwik\core\Tracker\Db\Mysqli.php on line 50
@sgiehl commented on December 19th 2019 Member

the deprecations in ini component were fixed in https://github.com/matomo-org/component-ini/pull/10

@brainfoolong commented on December 19th 2019 Contributor

Thx for info. This deprecated fix seems rather old. Should it already be in 3.13.0?

@Findus23 commented on December 19th 2019 Member

@brainfoolong Actually it hasn't been fully fixed until https://github.com/matomo-org/matomo/pull/15204 which will be released in the next release (or should already be in the beta)

@tsteur commented on December 19th 2019 Member

@Findus23 not sure if the component ini composer package has been updated in core already in the Matomo repository?

@Findus23 commented on December 20th 2019 Member

@tsteur I think it has, but for whatever reason the code in https://github.com/matomo-org/matomo/pull/15204 is used instead of the ini component and therefore the warning is still thrown. I think that function can be deleted, but I don't know for sure.

@tsteur commented on December 20th 2019 Member

@Findus23 if I see this right https://github.com/matomo-org/component-ini/pull/10 was merged end August but there was no new release for the ini component since then? https://github.com/matomo-org/component-ini/releases

@sgiehl commented on December 21st 2019 Member

We would need to merge that into a new 1.x release. As the 2.x releases will be used for Matomo 4 only...

@tsteur commented on December 21st 2019 Member

created a 1.x-dev branch in https://github.com/matomo-org/component-ini/compare/1.0.6...1.x-dev and then released 1.0.7... we will need to update composer.json to include that version

@tsteur commented on December 21st 2019 Member

also need to merge https://github.com/matomo-org/matomo-php-tracker/pull/52/files and create a new release and update composer

This Issue was closed on December 26th 2019
Powered by GitHub Issue Mirror