Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even more php 7.4 errors #15288

Closed
brainfoolong opened this issue Dec 19, 2019 · 9 comments · Fixed by #15315
Closed

Even more php 7.4 errors #15288

brainfoolong opened this issue Dec 19, 2019 · 9 comments · Fixed by #15315
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.13.1

Comments

@brainfoolong
Copy link
Contributor

Here are more php 7.4 errors running on 3.13.0

19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 236
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 250
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 250
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 257
[19-Dec-2019 05:26:43 UTC] PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\www\piwik\vendor\piwik\ini\src\IniReader.php on line 259
[19-Dec-2019 05:26:44 UTC] PHP Notice:  Trying to access array offset on value of type int in C:\www\piwik\core\Tracker\Db\Mysqli.php on line 50
@sgiehl
Copy link
Member

sgiehl commented Dec 19, 2019

the deprecations in ini component were fixed in matomo-org/component-ini#10

@brainfoolong
Copy link
Contributor Author

Thx for info. This deprecated fix seems rather old. Should it already be in 3.13.0?

@Findus23
Copy link
Member

@brainfoolong Actually it hasn't been fully fixed until #15204 which will be released in the next release (or should already be in the beta)

@Findus23 Findus23 added the answered For when a question was asked and we referred to forum or answered it. label Dec 19, 2019
@tsteur
Copy link
Member

tsteur commented Dec 19, 2019

@Findus23 not sure if the component ini composer package has been updated in core already in the Matomo repository?

@Findus23
Copy link
Member

@tsteur I think it has, but for whatever reason the code in #15204 is used instead of the ini component and therefore the warning is still thrown. I think that function can be deleted, but I don't know for sure.

@tsteur
Copy link
Member

tsteur commented Dec 20, 2019

@Findus23 if I see this right matomo-org/component-ini#10 was merged end August but there was no new release for the ini component since then? https://github.com/matomo-org/component-ini/releases

@sgiehl
Copy link
Member

sgiehl commented Dec 21, 2019

We would need to merge that into a new 1.x release. As the 2.x releases will be used for Matomo 4 only...

@tsteur
Copy link
Member

tsteur commented Dec 21, 2019

created a 1.x-dev branch in matomo-org/component-ini@1.0.6...1.x-dev and then released 1.0.7... we will need to update composer.json to include that version

@tsteur tsteur reopened this Dec 21, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 21, 2019
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed answered For when a question was asked and we referred to forum or answered it. labels Dec 21, 2019
@tsteur
Copy link
Member

tsteur commented Dec 21, 2019 •
edited

also need to merge https://github.com/matomo-org/matomo-php-tracker/pull/52/files and create a new release and update composer

@tsteur tsteur self-assigned this Dec 23, 2019
@tsteur tsteur mentioned this issue Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging a pull request may close this issue.

Fix more PHP 7.4 issues matomo-org/matomo
4 participants
@tsteur @sgiehl @brainfoolong @Findus23