@katebutler opened this Pull Request on December 18th 2019 Contributor

Fixes #12072

@sgiehl commented on February 17th 2020 Member

Guess Kate won't finish this PR, so I will take over...

@sgiehl commented on February 18th 2020 Member

I've updated the PR and fixed some obvious bugs, adjusted the tests and also made search category and count available as segments

Should be ready for a review now

@diosmosis commented on February 29th 2020 Member

There are some tests that are failing, including one UI test that looks non-trivial to fix, otherwise looks good to merge to me.

@sgiehl commented on March 2nd 2020 Member

@diosmosis the failing plugin tests simply needs to be update in the submodule. Would do that before merge. But which UI test are you referring to? I think all of those failing here might also fail on 4.x-dev. (some of them started failing after merging 3.x-dev to 4.x-dev)

@diosmosis commented on March 2nd 2020 Member

@sgiehl there was an actions report that was failing but I don't see it anymore, I'm not sure what happened there. I guess ignore my comment.

This Pull Request was closed on March 9th 2020
Powered by GitHub Issue Mirror