Improve detection of cgi in cli multi #15283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if it's possible but maybe a regular request is not using CGI, but then the CLI request is if `findPhpBinary` returns a cgi script?
|
just seeing this should be already done in https://github.com/matomo-org/matomo/blob/3.x-dev/core/CliMulti/CliPhp.php#L79-L84 ... |
tsteur
added a commit
that referenced
this pull request
Dec 18, 2019
replaces #15283 Noticed the user's instance was using listespeed https://www.php.net/manual/en/install.unix.litespeed.php which returned following ``` phpbinary: /usr/local/bin/lsphp phpbindir: /opt/alt/php72/usr/bin which php: /usr/local/bin/php ``` We would have used lsphp but this seems to print the hashbang and have other issues. see #15283
diosmosis
pushed a commit
that referenced
this pull request
Dec 22, 2019
replaces #15283 Noticed the user's instance was using listespeed https://www.php.net/manual/en/install.unix.litespeed.php which returned following ``` phpbinary: /usr/local/bin/lsphp phpbindir: /opt/alt/php72/usr/bin which php: /usr/local/bin/php ``` We would have used lsphp but this seems to print the hashbang and have other issues. see #15283
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
replaces matomo-org#15283 Noticed the user's instance was using listespeed https://www.php.net/manual/en/install.unix.litespeed.php which returned following ``` phpbinary: /usr/local/bin/lsphp phpbindir: /opt/alt/php72/usr/bin which php: /usr/local/bin/php ``` We would have used lsphp but this seems to print the hashbang and have other issues. see matomo-org#15283
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
replaces matomo-org#15283 Noticed the user's instance was using listespeed https://www.php.net/manual/en/install.unix.litespeed.php which returned following ``` phpbinary: /usr/local/bin/lsphp phpbindir: /opt/alt/php72/usr/bin which php: /usr/local/bin/php ``` We would have used lsphp but this seems to print the hashbang and have other issues. see matomo-org#15283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's possible but maybe a regular request is not using CGI, but then the CLI request is if
findPhpBinaryreturns a cgi script?See https://www.php.net/manual/en/function.shell-exec.php
In Matomo for WordPress seeing various reports where the output starts with
#!/usr/bin/env php.refs #15277
refs matomo-org/matomo-for-wordpress#135 (comment)
Trying to reproduce this locally this happens:
Where it prints x-powered by etc