Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove output that can be ignored in climulti #15277

Merged
merged 1 commit into from Dec 22, 2019
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 17, 2019

Not sure it's really needed and how it happens but I reckon it cannot hurt. We've seen some archiving errors in Matomo for WordPress when CLI archiving is used where the output starts with the console hashbang ...

Seeing this also in PHPUnit in https://github.com/sebastianbergmann/phpunit/blob/8.5.0/src/Util/PHP/AbstractPhpProcess.php#L268-L273 which was added to fix sebastianbergmann/phpunit#982 but the change doesn't seem related to that.

@tsteur tsteur added the Needs Review PRs that need a code review label Dec 17, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 17, 2019
@tsteur
Copy link
Member Author

tsteur commented Dec 18, 2019

See #15285 this could for example happen when using litespeed by the looks

@diosmosis diosmosis merged commit 36b1997 into 3.x-dev Dec 22, 2019
@diosmosis diosmosis deleted the climultirmhashbang branch December 22, 2019 06:43
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process Isolation and phpunit.phar install
2 participants