Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip password min length checks when disable_checks_usernames_attributes=1 #15270

Merged
merged 1 commit into from May 21, 2020
Merged

Skip password min length checks when disable_checks_usernames_attributes=1 #15270

merged 1 commit into from May 21, 2020

Conversation

lab-at-nohl
Copy link
Contributor

see disable_checks_usernames_attributes in config/globals.ini.php

@lab-at-nohl
Hard checks on credentials prevent external user db
f826905 
see disable_checks_usernames_attributes in config/globals.ini.php
@tsteur
Copy link
Member

tsteur commented Dec 15, 2019

Looks good. Thoughts @diosmosis or @sgiehl ?

@diosmosis
Copy link
Member

diosmosis commented Dec 15, 2019 •
edited

Looks good. The minimum password length check isn't all that useful anyway.

@lab-at-nohl
Copy link
Contributor Author

@tsteur, @diosmosis, @sgiehl

Any news on this? It just broke my update.

Travis CI does not look comprehensible.

@tsteur
Copy link
Member

tsteur commented May 21, 2020

👍

@tsteur tsteur merged commit 723e92f into matomo-org:3.x-dev May 21, 2020
@tsteur tsteur added this to the 3.13.6 milestone May 21, 2020
@lab-at-nohl lab-at-nohl deleted the patch-1 branch May 21, 2020 22:10
@mattab mattab changed the title Hard checks on credentials prevent external user db Skip password checks when disable_checks_usernames_attributes=1 Jun 4, 2020
@mattab mattab changed the title Skip password checks when disable_checks_usernames_attributes=1 Skip password checks when disable_checks_usernames_attributes=1 Jun 4, 2020
@mattab mattab changed the title Skip password checks when disable_checks_usernames_attributes=1 Skip password min length checks when disable_checks_usernames_attributes=1 Jun 4, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@lab-at-nohl @jonasgrilleres
Hard checks on credentials prevent external user db (matomo-org#15270)
ead3cdf 
see disable_checks_usernames_attributes in config/globals.ini.php
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@lab-at-nohl @jbuget
Hard checks on credentials prevent external user db (matomo-org#15270)
bebddf9 
see disable_checks_usernames_attributes in config/globals.ini.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lab-at-nohl @tsteur @diosmosis