New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProxySite related changes to let comparisons work properly #15265
Conversation
…e API Proxy is called directly.
@diosmosis looks good in general but wondering if https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37332/UIIntegrationTest_goals_individual_goal_updated.png |
Yes it's failing due to |
Modified the parameter to only apply to the top level API request. |
Tried a different approach, if the tests pass, would be useful to have on staging. |
@diosmosis this tests is still failing and not sure it's due to this PR ? https://travis-ci.org/matomo-org/matomo/jobs/625560724#L923 |
@diosmosis the change is on staging |
The updated changes seem to work. |
Looks like tests are passing now? BTW do you know why those tests are failing? Must be from some previous change? https://travis-ci.org/matomo-org/matomo/jobs/628335284#L1176-L1439 |
That's from another PR, shouldn't be related to this one (plugin builds not updated). Tests are passing, but I changed the code a bit to do that, can you take another look? |
Looks good @diosmosis |
…g#15265) * Make sure ProxySite will disable post processor in Visualization where API Proxy is called directly. * Use Request::process so events are used. * Remove disable_datatable_post_processing, since it will propagate. * Only disable for root API request. * Move nestedApiInvocationCount increment to top of method. * Directly filter referrer type labels since there are a small number of them (helps comparison & proxysite). * Fix regression. * Update expected test files. * Another regression fixed. * Try to fix build again. * fix tests
…g#15265) * Make sure ProxySite will disable post processor in Visualization where API Proxy is called directly. * Use Request::process so events are used. * Remove disable_datatable_post_processing, since it will propagate. * Only disable for root API request. * Move nestedApiInvocationCount increment to top of method. * Directly filter referrer type labels since there are a small number of them (helps comparison & proxysite). * Fix regression. * Update expected test files. * Another regression fixed. * Try to fix build again. * fix tests
Changes:
Request::process()
forSegmentEditor.getAll
calls.