@diosmosis opened this Pull Request on December 13th 2019 Member

Changes:

  • Make sure ProxySite will disable post processor in Visualization where API Proxy is called directly. Otherwise the target.
  • Use Request::process() for SegmentEditor.getAll calls.
@tsteur commented on December 16th 2019 Member
@diosmosis commented on December 16th 2019 Member

Yes it's failing due to disable_datatable_post_processing since it will get propagated to other requests. We'll probably want to get rid of this on staging.

@diosmosis commented on December 16th 2019 Member

Modified the parameter to only apply to the top level API request.

@diosmosis commented on December 16th 2019 Member

Tried a different approach, if the tests pass, would be useful to have on staging.

@tsteur commented on December 16th 2019 Member

@diosmosis this tests is still failing and not sure it's due to this PR ? https://travis-ci.org/matomo-org/matomo/jobs/625560724#L923

@tsteur commented on December 16th 2019 Member

@diosmosis the change is on staging

@diosmosis commented on December 20th 2019 Member

The updated changes seem to work.

@tsteur commented on December 22nd 2019 Member

Looks like tests are passing now?

BTW do you know why those tests are failing? Must be from some previous change? https://travis-ci.org/matomo-org/matomo/jobs/628335284#L1176-L1439

@diosmosis commented on December 23rd 2019 Member

That's from another PR, shouldn't be related to this one (plugin builds not updated).

Tests are passing, but I changed the code a bit to do that, can you take another look?

@tsteur commented on December 23rd 2019 Member

Looks good @diosmosis

This Pull Request was closed on December 24th 2019
Powered by GitHub Issue Mirror