@diosmosis looks good in general but wondering if https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37332/UIIntegrationTest_goals_individual_goal_updated.png
is maybe failing because of this change? Or another change?
Yes it's failing due to
disable_datatable_post_processing since it will get propagated to other requests. We'll probably want to get rid of this on staging.
Modified the parameter to only apply to the top level API request.
Tried a different approach, if the tests pass, would be useful to have on staging.
@diosmosis this tests is still failing and not sure it's due to this PR ? https://travis-ci.org/matomo-org/matomo/jobs/625560724#L923
The updated changes seem to work.
Looks like tests are passing now?
BTW do you know why those tests are failing? Must be from some previous change? https://travis-ci.org/matomo-org/matomo/jobs/628335284#L1176-L1439
That's from another PR, shouldn't be related to this one (plugin builds not updated).
Tests are passing, but I changed the code a bit to do that, can you take another look?