Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New implementation of generateUniqId() using random_bytes() #15263

Merged
merged 1 commit into from Jan 14, 2020
Merged

New implementation of generateUniqId() using random_bytes() #15263

merged 1 commit into from Jan 14, 2020

Conversation

katebutler
Copy link

Note that the random_bytes() function is only available in PHP 7. As we won't be supporting PHP 5.x in Matomo 4.0 I haven't implemented any backwards compatibility for this and there are many tests failing on PHP 5.6.

Fixes #13357

@katebutler katebutler added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Dec 11, 2019
@katebutler katebutler added this to the 4.0.0 milestone Dec 11, 2019
@katebutler katebutler added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Dec 18, 2019
@tsteur tsteur changed the base branch from 3.x-dev to 4.x-dev January 14, 2020 03:59
@tsteur tsteur merged commit bc25125 into 4.x-dev Jan 14, 2020
@tsteur tsteur deleted the 13357 branch January 14, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katebutler @tsteur