Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust cookie only when visitorId is set #15258

Merged
merged 1 commit into from Dec 15, 2019
Merged

Trust cookie only when visitorId is set #15258

merged 1 commit into from Dec 15, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 10, 2019

refs #15205

Since we no longer use the UserId as VisitorId I reckon this needs changing. I haven't tested anything but it seems logical to me. Otherwise there might be issues where no visitorId is set but a userId and then it always creates new visits.

refs #15205

Since we no longer use the UserId as VisitorId I reckon this needs changing. I haven't tested anything but it seems logical to me. Otherwise there might be issues where no visitorId is set but a userId and then it always creates new visits.
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 10, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 10, 2019
@diosmosis
Copy link
Member

LGTM, though there's a test failure in the PDF file. Strange it's just the PDF files...

@tsteur
Copy link
Member Author

tsteur commented Dec 11, 2019

@diosmosis that test is failing in some other PRs and I think 3.x-dev too

@diosmosis diosmosis merged commit ba1b821 into 3.x-dev Dec 15, 2019
@diosmosis diosmosis deleted the 15205 branch December 15, 2019 22:53
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
refs matomo-org#15205

Since we no longer use the UserId as VisitorId I reckon this needs changing. I haven't tested anything but it seems logical to me. Otherwise there might be issues where no visitorId is set but a userId and then it always creates new visits.
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
refs matomo-org#15205

Since we no longer use the UserId as VisitorId I reckon this needs changing. I haven't tested anything but it seems logical to me. Otherwise there might be issues where no visitorId is set but a userId and then it always creates new visits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants