New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent race conditions when updating plugin settings #15249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebutler
added
the
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
label
Dec 8, 2019
katebutler
added
Needs Review
PRs that need a code review
and removed
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
labels
Dec 18, 2019
tsteur
reviewed
Dec 18, 2019
tsteur
requested changes
Dec 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katebutler we'll need the changes for MeasurableSettingsTable
as well
…by MeasurableSettingsTable
…ven when not needed, simplify code by reusing existing logic
tsteur
added a commit
that referenced
this pull request
Dec 30, 2019
tsteur
added a commit
that referenced
this pull request
Dec 30, 2019
tsteur
added a commit
that referenced
this pull request
Dec 30, 2019
tsteur
added a commit
that referenced
this pull request
Dec 30, 2019
tsteur
added a commit
that referenced
this pull request
Dec 30, 2019
mattab
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Jan 16, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
…5249 (matomo-org#15325)" (matomo-org#15328) This reverts commit 520ba48.
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
…5249 (matomo-org#15325)" (matomo-org#15328) This reverts commit 520ba48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15234