Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent race conditions when updating plugin settings #15249

Merged
merged 6 commits into from Dec 22, 2019
Merged

Prevent race conditions when updating plugin settings #15249

merged 6 commits into from Dec 22, 2019

Conversation

katebutler
Copy link

Fixes #15234

@katebutler katebutler added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Dec 8, 2019
@katebutler katebutler added this to the 3.13.1 milestone Dec 8, 2019
@katebutler katebutler added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Dec 18, 2019
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katebutler we'll need the changes for MeasurableSettingsTable as well

@tsteur tsteur merged commit 954f6ce into 3.x-dev Dec 22, 2019
@tsteur tsteur deleted the 15234 branch December 22, 2019 21:21
tsteur added a commit that referenced this pull request Dec 30, 2019
tsteur added a commit that referenced this pull request Dec 30, 2019
tsteur added a commit that referenced this pull request Dec 30, 2019
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 16, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING: core/Settings/Storage/Storage.php(86): Notice - Array to string conversion
3 participants