Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BulkTracking plugin always activated #15248

Merged
merged 2 commits into from Jan 15, 2020
Merged

Make BulkTracking plugin always activated #15248

merged 2 commits into from Jan 15, 2020

Conversation

katebutler
Copy link

Fixes #14553

@katebutler katebutler added the Needs Review PRs that need a code review label Dec 8, 2019
@katebutler katebutler added this to the 4.0.0 milestone Dec 8, 2019
@tsteur tsteur changed the base branch from 3.x-dev to 4.x-dev January 14, 2020 03:59
sgiehl
sgiehl reviewed Jan 15, 2020
View reviewed changes
core/Plugin/Manager.php
@@ -70,6 +70,7 @@ public static function getInstance()

// These are always activated and cannot be deactivated
protected $pluginToAlwaysActivate = array(
'BulkTracking',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the plugin need to be added to the list in global.ini.php instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about making sure it is always activated and not be able to be deactivated. AFAIK it is in global.ini.php already. Or not sure if you mean something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure. I misread the title 🙈

@tsteur tsteur merged commit 23b96ee into 4.x-dev Jan 15, 2020
@tsteur tsteur deleted the 14533 branch January 15, 2020 20:03
@sgiehl sgiehl mentioned this pull request Feb 3, 2020
Closed
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

mark BulkTracking plugin as required, not deactivable
4 participants
@katebutler @tsteur @sgiehl @mattab