Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed URL in real-time-visitors module #15232

Closed
chipichanga opened this issue Dec 3, 2019 · 1 comment · Fixed by #15233
Closed

Malformed URL in real-time-visitors module #15232

chipichanga opened this issue Dec 3, 2019 · 1 comment · Fixed by #15233
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.13.1

Comments

@chipichanga
Copy link

While reviewing the actions section in the real-time-visitors module at the main board, I discovered the link to the downloaded content was broken. The issue there is that the generated URL for that link is not well formed. In this case, the system adds the protocol incorrectly and that makes the link to bring you nowhere.

As you can see in the attached screenshot, Matomo starts the URL with "http://https//" which takes the browser to "https//[uri-to-resource]" (missing the colon after the protocol), and that results in a broken link.

Thanks for taking care of this.

20191203_screenshot_matomo_malformed-URL
@tsteur
Copy link
Member

tsteur commented Dec 3, 2019

Cheers, I can reproduce this @chipichanga

This is actually an issue in Matomo core so will move it there and provide a workaround.

@tsteur tsteur transferred this issue from matomo-org/matomo-for-wordpress Dec 3, 2019
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Dec 3, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 3, 2019
@tsteur tsteur mentioned this issue Dec 3, 2019
Merged
tsteur added a commit to matomo-org/matomo-for-wordpress that referenced this issue Dec 3, 2019
@tsteur
refs matomo-org/matomo#15232 fix malformed download link
b71de80
@tsteur tsteur self-assigned this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging a pull request may close this issue.

Fix Malformed URL in real-time-visitors module matomo-org/matomo
2 participants
@tsteur @chipichanga