New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call hang and freeze browser #15229
Comments
Some news because we have the problem on button component. <button class="btn" [type]="type" [ngClass]="getClass()"
[attr.disabled]="loading || disabled ? 'disabled' : null"
(click)="clicked.emit($event)">
<ng-content></ng-content>
</button> getClass() {
const classes = [];
if (this.block) {
classes.push('btn-block');
}
if (this.size) {
classes.push(`btn-${this.size}`);
}
if (this.loading || this.outline) {
classes.push(`btn-outline-${this.color}`);
} else {
classes.push(`btn-${this.color}`);
}
return classes;
} The tab freezes because |
sorry could you explain a bit more where you use Angular 8? We are using Angular 1 here. Are you developing a plugin? We can't give any support for Angular 8. |
This is not going to be a simple issue. What surprises me is the very subtle difference between the working code and the freezing code : a simple line break. Since the Angular template is no real HTML code, it is being compiled as javascript for handling DOM modification, I find it surprising that a simple line break is changing the generated code, but it could be. Regarding Angular 8, are you using the new Ivy Renderer? If not, can you activate it (it is not by default) and check if anything changes? |
@tsteur, I just wanted to add that this issue may not be an easy one to decide what needs to be fixed. Some simple test application may need to be produced in order to reproduce it and understand what's going on. Then this issue may also need to be posted to the Angular team. |
@tsteur we are developing our projects with Angular 8 and we use @Arnaud73 's plugin https://github.com/Arnaud73/ngx-matomo but it seems to just wrap the api. Matomo is mandatory for us, that's why I'm posting here, I'm dicovering Matomo so maybe I'm in the wrong place ? I tried Ivy. After a very long compilation time, it broke the app with forms, so cannot use it :( |
You mean in the JS tracker? We're not adding any listeners to buttons unless you were to call the |
@mgohin, is there any chance you could come with a striped down version of your app that reproduces the problem? |
Maybe this bug should be created in https://github.com/Arnaud73/ngx-matomo directly? |
As a workaround I fount this working solution
|
We use Angular 8 with ngx-translate in our project and sometimes matomo call doesn't end so it freezes the page.
called url by matomo :
This syntax makes it fail, and it's about the line-break between
translate
and</button>
But this one works :
And this one too
So I guess matomo tracks the button but fail on this one. Can you guide me how to avoid that kind of troubles (and please don't tell me to change the html syntax :) )
The text was updated successfully, but these errors were encountered: