Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix site selector shows undefined in custom dimensions #15228

Merged
merged 1 commit into from Dec 8, 2019
Merged

Fix site selector shows undefined in custom dimensions #15228

merged 1 commit into from Dec 8, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 3, 2019

fix DEV-1827

Needed because otherwise the sites selector shows otherwise undefined as site name when https://github.com/matomo-org/plugin-CustomDimensions/pull/136/files is merged

@tsteur
Update Controller.php
f1a5642 
fix DEV-1827

Needed because otherwise the sites selector shows  otherwise undefined as site name when https://github.com/matomo-org/plugin-CustomDimensions/pull/136/files is merged
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 3, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 3, 2019
@diosmosis diosmosis merged commit 4570111 into 3.x-dev Dec 8, 2019
@diosmosis diosmosis deleted the DEV-1827 branch December 8, 2019 03:52
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tsteur @jonasgrilleres
Update Controller.php (matomo-org#15228)
859a6d5 
fix DEV-1827

Needed because otherwise the sites selector shows  otherwise undefined as site name when https://github.com/matomo-org/plugin-CustomDimensions/pull/136/files is merged
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tsteur @jbuget
Update Controller.php (matomo-org#15228)
e46e5b0 
fix DEV-1827

Needed because otherwise the sites selector shows  otherwise undefined as site name when https://github.com/matomo-org/plugin-CustomDimensions/pull/136/files is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis