Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test cookie may be set multiple times #15225

Merged
merged 3 commits into from Dec 10, 2019
Merged

Fix test cookie may be set multiple times #15225

merged 3 commits into from Dec 10, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 2, 2019 •
edited

  • Make sure to not set a test cookie per site but instead use one test cookie overall
  • Only set test cookie on IE or browsers that support modal dialog
  • Delete the test cookie after it has been set testcookies are always set #15161 (comment)

fix #15209

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 2, 2019
@tsteur tsteur added this to the 3.13.1 milestone Dec 2, 2019
This was referenced Dec 2, 2019
Closed
Closed
@tsteur tsteur mentioned this pull request Dec 4, 2019
Closed
@diosmosis diosmosis merged commit 82ba03f into 3.x-dev Dec 10, 2019
@diosmosis diosmosis deleted the 15209 branch December 10, 2019 23:38
@dirk-graetz
Copy link

_pk_test cookie..undefined is still be set

@utrautmann
Copy link

Two test cookies are still set in Firefox with Matomo 3.13.3.
I do not use the disable-cookies setting, but multiple domains.
These are the activated settings:
_paq.push (["setCookieDomain", "* ..."]);
         _paq.push (["setDomains", ["* ....", "* ...."]]);
         _paq.push (["enableCrossDomainLinking"]);
         _paq.push (['trackPageView']);
         _paq.push (['enableLinkTracking']);

jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tsteur @jonasgrilleres
Fix test cookie may be set multiple times (matomo-org#15225)
210b1d0 
* Fix test cookie may be set multiple times

* make sure to delete test cookie after setting it

* fix tests
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tsteur @jbuget
Fix test cookie may be set multiple times (matomo-org#15225)
17fa5e7 
* Fix test cookie may be set multiple times

* make sure to delete test cookie after setting it

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

Too many cookies on one domain result in weird browser behaviour
4 participants
@tsteur @dirk-graetz @utrautmann @diosmosis