Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide visitor map controls if no data is available #15223

Merged
merged 5 commits into from Feb 3, 2020
Merged

Hide visitor map controls if no data is available #15223

merged 5 commits into from Feb 3, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 2, 2019

fixes #8505

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 2, 2019
@tsteur tsteur added this to the 4.0.0 milestone Dec 2, 2019
@tsteur tsteur changed the base branch from 3.x-dev to 4.x-dev January 14, 2020 03:58
@tsteur
Copy link
Member

tsteur commented Jan 26, 2020

@sgiehl
When I view it now, it looks like this:

image

I wonder if we should maybe add a title to the widget? Or maybe only when there is no data? Or incorporate it somehow into the no data message?

No preference. Might otherwise just be confusing that no title or indication is shown which report has no data.

tsteur
tsteur requested changes Jan 26, 2020
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@sgiehl
Copy link
Member Author

sgiehl commented Jan 27, 2020

It should now show the widget title if there is now data for the map

@tsteur
Copy link
Member

tsteur commented Jan 27, 2020

Looks good 👍
could you check why it seems the info icon is now gone in https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/38014/VisitorMap_cities.png and https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/38014/VisitorMap_regions.png

Once they are fixed feel free to merge

@sgiehl
Copy link
Member Author

sgiehl commented Feb 3, 2020

Those changes are valid. The icon shows the number of unlocated visits on hover. The icon is now hidden, if there are no unlocated visits, which is the case in the UI tests. Will update the screenshots and merge afterwards

@sgiehl sgiehl merged commit cbe2709 into 4.x-dev Feb 3, 2020
@sgiehl sgiehl deleted the hidemapcontrols branch February 3, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Visitor map shows info icon but no tooltip when there is no data
2 participants
@sgiehl @tsteur