Several PHP 7.4 fixes #15222
Merged
Several PHP 7.4 fixes #15222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a fresh 3.13.0 install with php 7.4.0 following error occurs when tracker does track a page view, when using Mysqli as database driver. `Notice: Trying to access array offset on value of type int in /srv/0x.at/matomo/core/Tracker/Db/Mysqli.php on line 50` This fix this error
This error appears, this change fixes this issue `DataTable/Filter/ColumnDelete.php(164): Deprecated - array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead - Matomo 3.11.0`
brainfoolong
changed the title
tsteur
reviewed
Dec 2, 2019
| @@ -161,7 +161,7 @@ protected function removeColumnsFromTable(&$table) | |||
| } | |||
| foreach ($this->columnsToRemove as $column) { | |||
|
|
|||
| if (!array_key_exists($column, $row)) { | |||
| if (!property_exists($column, $row)) { | |||
There was a problem hiding this comment.
Could you maybe undo this change? We will investigate this as part of #15210
As suggested here https://github.com/matomo-org/matomo/pull/15222/files/cba4f22e12a23ec392f45decceedc49e5753eea5#diff-a5f249b6134f80011f165be56c5995b1 This wasn't a proper fix, i got other errors after applying that.
|
Awesome, thanks for quick change. Very appreciated. |
tsteur
approved these changes
Dec 2, 2019
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a fresh 3.13.0 install with php 7.4.0 following error occurs when tracker does track a page view, when using Mysqli as database driver.
Notice: Trying to access array offset on value of type int in /srv/0x.at/matomo/core/Tracker/Db/Mysqli.php on line 50This fix this error