Ensure named character references without a tailing semicolon won't be replaced in transition urls #15221

sgiehl · 2019-12-02T15:47:30Z

I've debugged the issue of #10733 for a while now, and the real issue is here:

matomo/plugins/Actions/javascripts/rowactions.js

Lines 21 to 28 in 3f26e78

    
           function getLinkForTransitionAndOverlayPopover(tr) 
        
           { 
        
               tr = getRealRowIfComparisonRow(tr); 
        
               var link = tr.find('> td:first > a').attr('href'); 
        
               link = $('<textarea>').html(link).val(); // remove html entities 
        
               return link; 
        
           }

Decoding the html entities also converts stuff like &reg into ®. That also happens without the tailing ; as various named references don't need it. See https://html.spec.whatwg.org/multipage/named-characters.html#named-character-references

…e replaced in transition urls

Ensure named character references without a tailing semicolon won't b…

a1118f0

…e replaced in transition urls

sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 2, 2019

sgiehl force-pushed the transitionencoding branch from ba798d4 to a1118f0 Compare December 2, 2019 15:47

tsteur modified the milestones: 4.1.0, 4.0.0 Dec 2, 2019

tsteur changed the base branch from 3.x-dev to 4.x-dev January 14, 2020 03:58

tsteur merged commit b5679e1 into 4.x-dev Jan 26, 2020

tsteur deleted the transitionencoding branch January 26, 2020 23:54

sgiehl mentioned this pull request Apr 28, 2020

Transition plugin can't handle named characters in URL #10733

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure named character references without a tailing semicolon won't be replaced in transition urls #15221

Ensure named character references without a tailing semicolon won't be replaced in transition urls #15221

sgiehl commented Dec 2, 2019

	function getLinkForTransitionAndOverlayPopover(tr)
	{
	tr = getRealRowIfComparisonRow(tr);

	var link = tr.find('> td:first > a').attr('href');
	link = $('<textarea>').html(link).val(); // remove html entities
	return link;
	}

Ensure named character references without a tailing semicolon won't be replaced in transition urls #15221

Ensure named character references without a tailing semicolon won't be replaced in transition urls #15221

Conversation

sgiehl commented Dec 2, 2019