fix PNG interlacing #15219
Merged
fix PNG interlacing #15219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Findus23 cheers for that. Looks like a few installation screenshots need to be updated: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37208/ Will you have time for this? |
tsteur
added
Needs Review
|
@tsteur Should be done ✔️ |
|
Cheers @Findus23 |
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15216
According to https://tex.stackexchange.com/a/472462/66733 this bug is triggered in libpng when opening PNG files with Interlacing.
Find all interlaced PNGs in
plugins/Morpheus/images:Remove interlacing:
mogrify -interlace none logo*Remove execution rights (while we are at it):
chmod -x logo*optimize the PNG losslessy:
optipng -o 9 logo*.pngLet's hope noone has a internet connection slow enough that they can watch single pixel appear while loading a 4KB image (who would benefit from interlacing).