@sgiehl opened this Pull Request on December 2nd 2019 Member

number formatting is meanwhile done somewhere else. For some local formats this second formatting breaks the numbers...

fixes #15200

@tsteur commented on December 2nd 2019 Member
@sgiehl commented on December 2nd 2019 Member

I guess that is kind of expected. The generation time is a computed metric. But when no generation time has been tracked, the metric is not computed and thus the value is actually false. Because of that the metric won't get formatted in https://github.com/matomo-org/matomo/blob/3f26e785f015d30d0aeea66aaf7484111b0dbfa9/core/Metrics/Formatter.php#L201-L203
But as the sparklines are using a number filter for the values it gets converted to 0 in https://github.com/matomo-org/matomo/blob/f1d6cc7618221813699c0f8c0d97e5c41c48d323/plugins/CoreVisualizations/templates/macros.twig#L37-L41

@tsteur commented on December 2nd 2019 Member

OK might need to update the tests then 👍

@sgiehl commented on December 9th 2019 Member

tests are updated now

This Pull Request was closed on December 9th 2019
Powered by GitHub Issue Mirror