Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgetConsentGiven method lasts 7 days instead of 30 years #15214

Closed
wlabarron opened this issue Dec 1, 2019 · 4 comments
Closed

forgetConsentGiven method lasts 7 days instead of 30 years #15214

wlabarron opened this issue Dec 1, 2019 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@wlabarron
Copy link

wlabarron commented Dec 1, 2019

Related to #14487.

matomo/js/piwik.js

Lines 7597 to 7600 in 54dadb9

var thirtyYears = 30 * 365 * 24 * 60 * 60 * 1000;
deleteCookie(CONSENT_COOKIE_NAME, configCookiePath, configCookieDomain);
setCookie(CONSENT_REMOVED_COOKIE_NAME, new Date().getTime(), thirtyYears, configCookiePath, configCookieDomain, configCookieIsSecure);

This code suggests that the consent forgotten cookie should last for 30 years, but when I call the function from the console in Safari on macOS and look at the cookie in the inspector, it's only set to last 7 days.

Running Matomo v3.13.0.

@Findus23
Copy link
Member

Findus23 commented Dec 1, 2019

@wlabarron
Copy link
Author

Ah okay, that makes sense - I did think it was very odd. Thank you.

@Findus23 Findus23 added the answered For when a question was asked and we referred to forum or answered it. label Dec 2, 2019
@mattab
Copy link
Member

mattab commented Mar 25, 2020

Confirmed, we just re-discovered this issue, posted a comment for reference in #14819 (comment)

@mattab
Copy link
Member

mattab commented Mar 25, 2020

fyi created PR to document this limitation matomo-org/developer-documentation#336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

3 participants