@wThomas84 opened this Pull Request on November 21st 2013

Pull request for the enhancements as discussed in this thread: http://forum.piwik.org/read.php?2,107159,page=1#msg-107379

My last pull request let the tests fail. Maybe it is due to the tests do not take into account that method signature(s) have changed, especially in Cookie.php, l.86. Unfortunately I do not know where and what to adapt and what exactly failed, due to I cannot find any details in Travis overview.
Help will be appreciated.

@mattab commented on December 8th 2013 Member

Cheers for the PR!

Build fails because you write PiwikConfig instead of Config (we are now using PHP namespaces so the Piwik prefix is not required)

--> please consider testing the code before making the pull request ;)

@mattab commented on December 23rd 2013 Member

Please reopen the PR when you got a chance to update it with latest Piwik. Cheers

This Pull Request was closed on December 23rd 2013
Powered by GitHub Issue Mirror