Allow wildcard domain for 3rd party cookies to be set explicitly in conf... #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig.ini.php Extend Cookie constructor to accept domain In order to be able to set a 3rd party cookie's domain explicitly (so that the browser accepts it and sets it to the correct domain), the constructor was adapted to accept a cookie domain parameter. The concerning usages of that constructor were adapted as well. Now it is possible to put a line 'cookie_domain = ",mydomain.tld" ' into the config.ini.php that will be used by piwik. Cookie domain parsing adjusted The changes make sure that cookie wildcard domains always follow the pattern ".<domain_name>", independent of the domain that was configured in the config.ini.php for the key "cookie_domain". Add cookie_domain entry to global configuration
|
Cheers for the PR! Build fails because you write Piwik_Config instead of Config (we are now using PHP namespaces so the Piwik_ prefix is not required) --> please consider testing the code before making the pull request ;) |
|
Please reopen the PR when you got a chance to update it with latest Piwik. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the enhancements as discussed in this thread: http://forum.piwik.org/read.php?2,107159,page=1#msg-107379
My last pull request let the tests fail. Maybe it is due to the tests do not take into account that method signature(s) have changed, especially in Cookie.php, l.86. Unfortunately I do not know where and what to adapt and what exactly failed, due to I cannot find any details in Travis overview.
Help will be appreciated.