tracker debug fixes in CLI command + extra logs for Lock #15197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
changed the title
tsteur
reviewed
Nov 28, 2019
| @@ -10,6 +10,14 @@ function isTrackerDebugEnabled(ContainerInterface $c) | |||
|
|
|||
| return array( | |||
|
|
|||
| 'ini.log.log_writers' => DI\decorate(function ($previous, ContainerInterface $c) { | |||
| if (isTrackerDebugEnabled($c)) { | |||
| $previous[] = 'screen'; | |||
There was a problem hiding this comment.
Do we really always want to add logging to screen? I reckon many users would have an interest to only log this to file but not screen. Maybe we shouldn't force it? If someone can enable tracker debug in the config file, then they can maybe also add the logging to screen if needed?
There was a problem hiding this comment.
I think this is just for CLI processes, so I'll just add a check for whether in the CLI command as well.
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tracker debug when used in a CLI command (like queuedtracking:process).