Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare to: previous year (day) goes back two years #15193

Closed
tassoman opened this issue Nov 25, 2019 · 1 comment · Fixed by #15583
Closed

Compare to: previous year (day) goes back two years #15193

tassoman opened this issue Nov 25, 2019 · 1 comment · Fixed by #15583
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.0.0

Comments

@tassoman
Copy link
Contributor

I was testing the new comparing feature inside the calendar and I found this.

  1. select period = day (for example 5 nov 2018)
  2. check ✔️ «Compare in» then select «Previous year»

I expected a compared dashobard of 2018-11-05 day period and 2017-11-05 day period but query is ran with 2016-11-05 CompareDates[] and ComparePeriods[] = range.

Then I've expected I can compare day periods and not custom ranges.
This means to me Matomo is always calculating a range report. Not using pre-archived periods.

Note: «Compare to: previous period» works like expected
@tassoman tassoman mentioned this issue Nov 25, 2019
Closed
@tassoman
Copy link
Contributor Author

When the query is done, if I open it in a new session (incognito for example), «compare to:» previous period is selected inside the calendar-dropdown, but previous year query has ran.
You can have a try in demo also.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 21, 2020
@mattab mattab added this to the 4.2.0 milestone Jan 21, 2020
@sgiehl sgiehl mentioned this issue Feb 17, 2020
Closed
@sgiehl sgiehl self-assigned this Feb 17, 2020
@sgiehl sgiehl mentioned this issue Feb 17, 2020
Merged
@Findus23 Findus23 linked a pull request Feb 17, 2020 that will close this issue
Fixes some comparison issues #15583
Merged
@mattab mattab modified the milestones: 4.2.0, 4.0.0 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Fixes some comparison issues matomo-org/matomo
3 participants
@tassoman @mattab @sgiehl