Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support webpack instead of relying solely on JShrink #15190

Closed
diosmosis opened this issue Nov 23, 2019 · 1 comment
Closed

Support webpack instead of relying solely on JShrink #15190

diosmosis opened this issue Nov 23, 2019 · 1 comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Milestone
Priority Backlog ...

Comments

@diosmosis
Copy link
Member

In order to support using TypeScript, Angular and a better less compiler in the future we should consider allowing webpack in the development workflow.

A possible way to do this would be to run webpack on build via some sort of build-js command. this would be run by matomo-package when generating the default matomo package, and for plugins on the marketplace when deploying new versions. (Doing it this way means we don't have to require node on users' machines.)

Using it for less compilation is generally more of an issue since it would break theming.
@diosmosis diosmosis added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Nov 23, 2019
@Findus23 Findus23 added the RFC Indicates the issue is a request for comments where the author is looking for feedback. label May 23, 2020
@mattab
Copy link
Member

mattab commented Dec 10, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
4 participants
@diosmosis @mattab @sgiehl @Findus23