Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appropriate SameSite value for session cookie #15186

Merged
merged 3 commits into from Dec 9, 2019
Merged

Use appropriate SameSite value for session cookie #15186

merged 3 commits into from Dec 9, 2019

Conversation

katebutler
Copy link

Part of #14395

tsteur
tsteur reviewed Nov 24, 2019
View reviewed changes
core/Session.php Outdated Show resolved Hide resolved
@katebutler katebutler added the Needs Review PRs that need a code review label Nov 24, 2019
@katebutler katebutler added this to the 3.13.0 milestone Nov 24, 2019
@mattab mattab modified the milestones: 3.13.0, 3.13.1 Nov 27, 2019
@tsteur
Copy link
Member

tsteur commented Dec 7, 2019

@Findus23 @MichaelHeerklotz any chance you could give this PR a test as well?

@tsteur tsteur merged commit eec0711 into 3.x-dev Dec 9, 2019
@tsteur tsteur deleted the 14395-session branch December 9, 2019 23:53
@igugigu igugigu mentioned this pull request Jan 22, 2020
Closed
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@jonasgrilleres
Use appropriate SameSite value for session cookie (matomo-org#15186)
440c156 
* Set SameSite=lax for session cookie

* Update warning text when Matomo is installed on HTTP

* urlencode all session cookie values
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@jbuget
Use appropriate SameSite value for session cookie (matomo-org#15186)
b9579e2 
* Set SameSite=lax for session cookie

* Update warning text when Matomo is installed on HTTP

* urlencode all session cookie values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katebutler @tsteur @mattab