Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spyc to 0.6.X #15183

Merged
merged 1 commit into from Nov 22, 2019
Merged

Update spyc to 0.6.X #15183

merged 1 commit into from Nov 22, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 21, 2019

@sgiehl any thoughts on that? I reckon shouldn't be an issue?

I was getting this error in WordPress:

Cannot declare class Spyc, because the name is already in use

Because it doesn't use the regular autoloader and Spyc's autoloader/class is loaded on every request. Only in 0.6.X they are checking if the class is already loaded and don't redeclare it https://github.com/mustangostang/spyc/blob/0.6.3/Spyc.php#L46 compared to before they always tried to redeclare it https://github.com/mustangostang/spyc/blob/0.5.1/Spyc.php#L57

This is basically needed for WordPress to:

  • Have better compatibility with other WP plugins
  • Support WP-CLI

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 21, 2019
@tsteur tsteur added this to the 3.13.0 milestone Nov 21, 2019
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. shouldn't be a problem to update it.

@tsteur tsteur merged commit 4e187d1 into 3.x-dev Nov 22, 2019
@tsteur tsteur deleted the spyc06 branch November 22, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants