Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lessphp to use branch for php 7.4 compatibility. #15180

Merged
merged 1 commit into from Nov 21, 2019
Merged

Update lessphp to use branch for php 7.4 compatibility. #15180

merged 1 commit into from Nov 21, 2019

Conversation

diosmosis
Copy link
Member

Fixes #14821

Should be the last thing to do in the ticket.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 21, 2019
@diosmosis diosmosis added this to the 3.13.0 milestone Nov 21, 2019
@diosmosis
Copy link
Member Author

Think you could take a look @Findus23 ?

Findus23
Findus23 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but looks good to me.

@diosmosis diosmosis merged commit c0b5d66 into 3.x-dev Nov 21, 2019
@diosmosis diosmosis deleted the lessphp-update branch November 21, 2019 10:39
@Findus23 Findus23 mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Findus23 Findus23 Findus23 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

Make Matomo compatible with PHP 7.4
2 participants
@diosmosis @Findus23