Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix region mappings for map widget where possible #15168

Merged
merged 106 commits into from Nov 28, 2019
Merged

Fix region mappings for map widget where possible #15168

merged 106 commits into from Nov 28, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 18, 2019

Due to switching from FIPS to ISO with GeoIP2, almost all region maps are currently not showing any visits.
By adding the ISO codes to the existing maps (where an exact mapping is possible), the visits for regions should be shown for more regions again.
Some of the maps will still be broken or show incorrect data, as the iso codes can't be added everywhere.

refs #13347

@sgiehl sgiehl added this to the 3.13.0 milestone Nov 18, 2019
@sgiehl sgiehl changed the title Fix some region mappings for map widget Fix region mappings for map widget where possible Nov 25, 2019
@sgiehl sgiehl marked this pull request as ready for review November 25, 2019 10:18
@sgiehl
Copy link
Member Author

sgiehl commented Nov 25, 2019

This should fix/improve the region mappings for most countries. For some countries a proper mapping isn't possible as they were completely reorganized, they will still show no data for GeoIp2. For some others the new mapping might not be fully exact, but it should be at least better than having none.

@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 25, 2019
@mattab mattab modified the milestones: 3.13.0, 3.13.1 Nov 27, 2019
@tsteur
Copy link
Member

tsteur commented Nov 28, 2019

@sgiehl as the tests pass I reckon it's maybe good to merge? Or should we maybe wait to Matomo 4 since it's not a priority right now and the original issue is scheduled for matomo 4? Not sure how to test it so feel free to merge.

@sgiehl
Copy link
Member Author

sgiehl commented Nov 28, 2019

@tsteur We still need to create completely new maps for Matomo 4. But as that might take some more time, I thought it might be useful to fix most of the region maps to work correctly with GeoIP2. It was not possible for all countries, as a mapping from FIPS to GeoIP2 ist not possible (e.g. for France).
To test that, you can simply generate some visits and check if the regions on the maps are highlighted. (Only US and CA were already working before this change)

@tsteur
Copy link
Member

tsteur commented Nov 28, 2019

image
image

worked.

@tsteur tsteur merged commit 736afbe into 3.x-dev Nov 28, 2019
@tsteur tsteur deleted the mapfixes branch November 28, 2019 20:04
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants